[ 
https://issues.apache.org/jira/browse/YARN-2705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14175665#comment-14175665
 ] 

Hadoop QA commented on YARN-2705:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12675585/YARN-2705-20141017-1.patch
  against trunk revision 209b169.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 6 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager:

                  org.apache.hadoop.yarn.nodelabels.TestCommonNodeLabelsManager
                  
org.apache.hadoop.yarn.nodelabels.TestFileSystemNodeLabelsStore

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/5444//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5444//console

This message is automatically generated.

> Changes of RM node label manager default configuration
> ------------------------------------------------------
>
>                 Key: YARN-2705
>                 URL: https://issues.apache.org/jira/browse/YARN-2705
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: api, client, resourcemanager
>            Reporter: Wangda Tan
>            Assignee: Wangda Tan
>            Priority: Critical
>         Attachments: YARN-2705-20141017-1.patch, YARN-2705-20141017-2.patch
>
>
> 1) Add yarn.node-labels.manager-class, by default it's will not store 
> anything to file system
> 2) Use above at least in some places: RMNodeLabelsManager, RMAdminCLI. 
> Convert {{DummyNodeLabelsManager}} into a {{MemoryNodeLabelsManager}}
> 3) Document that RM configs and client configs for 
> yarn.node-labels.manager-class should match
> 4) fs-store.uri -> fs-store.root-dir
> 5) Similarly FS_NODE_LABELS_STORE_URI
> 6) For default value of fs-store.uri, put it in /tmp. But creaat 
> /tmp/hadoop-yarn-$\{user\}/node-labels



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to