[
https://issues.apache.org/jira/browse/YARN-2701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180119#comment-14180119
]
zhihai xu commented on YARN-2701:
---------------------------------
One nit in the addendum patch:
Can we change
{code}
if (stat(path, &sb) == 0) {
if (check_dir(path, sb.st_mode, perm, 1) == -1) {
return -1;
}
return 0;
}
{code}
to
{code}
if (stat(path, &sb) == 0) {
return check_dir(path, sb.st_mode, perm, 1);
}
{code}
> Potential race condition in startLocalizer when using LinuxContainerExecutor
> ------------------------------------------------------------------------------
>
> Key: YARN-2701
> URL: https://issues.apache.org/jira/browse/YARN-2701
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Xuan Gong
> Assignee: Xuan Gong
> Priority: Blocker
> Fix For: 2.6.0
>
> Attachments: YARN-2701.1.patch, YARN-2701.2.patch, YARN-2701.3.patch,
> YARN-2701.4.patch, YARN-2701.5.patch, YARN-2701.6.patch,
> YARN-2701.addendum.1.patch
>
>
> When using LinuxContainerExecutor do startLocalizer, we are using native code
> container-executor.c.
> {code}
> if (stat(npath, &sb) != 0) {
> if (mkdir(npath, perm) != 0) {
> {code}
> We are using check and create method to create the appDir under /usercache.
> But if there are two containers trying to do this at the same time, race
> condition may happen.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
