[
https://issues.apache.org/jira/browse/YARN-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14180456#comment-14180456
]
Wangda Tan commented on YARN-2727:
----------------------------------
[~Naganarasimha],
Thanks for the patch, some comments:
1)
bq. + port =
Integer.valueOf(nodeIdStr.substring(nodeIdStr.indexOf(":")+1));
As convention, please leave a space before and after "+"
2)
{code}
+ // no labels, should fail
+ args = new String[] { "-replaceLabelsOnNode" };
+ assertTrue(0 != rmAdminCLI.run(args));
+
+ // no labels, should fail
+ args =
+ new String[] { "-replaceLabelsOnNode",
+ "-directlyAccessNodeLabelStore" };
+ assertTrue(0 != rmAdminCLI.run(args));
{code}
These two check were already included by {{testReplaceLabelsOnNode}}
Thanks,
> In RMAdminCLI usage display, instead of "yarn.node-labels.fs-store.root-dir",
> "yarn.node-labels.fs-store.uri" is being displayed
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: YARN-2727
> URL: https://issues.apache.org/jira/browse/YARN-2727
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Reporter: Naganarasimha G R
> Assignee: Naganarasimha G R
> Priority: Minor
> Attachments: YARN-2727.20141023.1.patch
>
>
> In org.apache.hadoop.yarn.client.cli.RMAdminCLI usage display instead of
> "yarn.node-labels.fs-store.root-dir", "yarn.node-labels.fs-store.uri" is
> being used
> And also some modifications for the description
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
