[ https://issues.apache.org/jira/browse/YARN-2753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14203469#comment-14203469 ]
Hudson commented on YARN-2753: ------------------------------ FAILURE: Integrated in Hadoop-Mapreduce-trunk #1951 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1951/]) YARN-2753. Fixed a bunch of bugs in the NodeLabelsManager classes. Contributed by Zhihai xu. (vinodkv: rev 4cfd5bc7c18bb9a828f573b5c4d2b13fa28e732a) * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/nodelabels/TestRMNodeLabelsManager.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/nodelabels/CommonNodeLabelsManager.java > Fix potential issues and code clean up for *NodeLabelsManager > ------------------------------------------------------------- > > Key: YARN-2753 > URL: https://issues.apache.org/jira/browse/YARN-2753 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: zhihai xu > Assignee: zhihai xu > Fix For: 2.6.0 > > Attachments: YARN-2753.000.patch, YARN-2753.001.patch, > YARN-2753.002.patch, YARN-2753.003.patch, YARN-2753.004.patch, > YARN-2753.005.patch, YARN-2753.006.patch, YARN-2753.007.patch, > YARN-2753.008.patch > > > Issues include: > * CommonNodeLabelsManager#addToCluserNodeLabels should not change the value > in labelCollections if the key already exists otherwise the Label.resource > will be changed(reset). > * potential NPE(NullPointerException) in checkRemoveLabelsFromNode of > CommonNodeLabelsManager. > ** because when a Node is created, Node.labels can be null. > ** In this case, nm.labels; may be null. So we need check originalLabels not > null before use it(originalLabels.containsAll). > * addToCluserNodeLabels should be protected by writeLock in > RMNodeLabelsManager.java. because we should protect labelCollections in > RMNodeLabelsManager. > * Fix a potential bug in CommonsNodeLabelsManager, after serviceStop(...) is > invoked, some event may not be processed, see > [comment|https://issues.apache.org/jira/browse/YARN-2753?focusedCommentId=14197206&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14197206] -- This message was sent by Atlassian JIRA (v6.3.4#6332)