[ https://issues.apache.org/jira/browse/YARN-2802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14216635#comment-14216635 ]
Anubhav Dhoot commented on YARN-2802: ------------------------------------- This metric probably will not catch issues with queue configuration, so cluster wide might be fine. But in general adding to queue metrics should give both queue specific metrics plus cluster wide metrics by using the root queue metrics. Just gives us more granular data. For this patch, 1. Can we please use separate variables for the two uses of launchAMStartTime. In AMLaunchedTransition we should use a new variable at {{appAttempt.launchAMStartTime = System.currentTimeMillis();}} 2. In TestQueueMetrics we are adding to the metrics but not checking it. It would be good to check the value back is possible. > add AM container launch and register delay metrics in QueueMetrics to help > diagnose performance issue. > ------------------------------------------------------------------------------------------------------ > > Key: YARN-2802 > URL: https://issues.apache.org/jira/browse/YARN-2802 > Project: Hadoop YARN > Issue Type: Improvement > Components: resourcemanager > Affects Versions: 2.5.0 > Reporter: zhihai xu > Assignee: zhihai xu > Attachments: YARN-2802.000.patch, YARN-2802.001.patch, > YARN-2802.002.patch, YARN-2802.003.patch > > > add AM container launch and register delay metrics in QueueMetrics to help > diagnose performance issue. > Added two metrics in QueueMetrics: > aMLaunchDelay: the time spent from sending event AMLauncherEventType.LAUNCH > to receiving event RMAppAttemptEventType.LAUNCHED in RMAppAttemptImpl. > aMRegisterDelay: the time waiting from receiving event > RMAppAttemptEventType.LAUNCHED to receiving event > RMAppAttemptEventType.REGISTERED(ApplicationMasterService#registerApplicationMaster) > in RMAppAttemptImpl. -- This message was sent by Atlassian JIRA (v6.3.4#6332)