[ https://issues.apache.org/jira/browse/YARN-2404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224012#comment-14224012 ]
Jian He commented on YARN-2404: ------------------------------- looks good, one minor thing: we could just do return after checking attemptTokens == null {code} if(attemptTokens == null) { builder.clearAppAttemptTokens(); } {code} > Remove ApplicationAttemptState and ApplicationState class in RMStateStore > class > -------------------------------------------------------------------------------- > > Key: YARN-2404 > URL: https://issues.apache.org/jira/browse/YARN-2404 > Project: Hadoop YARN > Issue Type: Sub-task > Reporter: Jian He > Assignee: Tsuyoshi OZAWA > Attachments: YARN-2404.1.patch, YARN-2404.2.patch, YARN-2404.3.patch, > YARN-2404.4.patch, YARN-2404.5.patch, YARN-2404.6.patch, YARN-2404.7.patch > > > We can remove ApplicationState and ApplicationAttemptState class in > RMStateStore, given that we already have ApplicationStateData and > ApplicationAttemptStateData records. we may just replace ApplicationState > with ApplicationStateData, similarly for ApplicationAttemptState. -- This message was sent by Atlassian JIRA (v6.3.4#6332)