[ https://issues.apache.org/jira/browse/YARN-2738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14225568#comment-14225568 ]
Karthik Kambatla commented on YARN-2738: ---------------------------------------- Is there a reason to specify which queues are reservable? Why not make all leaf-queues reservable? By leaf-queues, I mean those under which we create {{reserved}} and {{unreserved}} queues. I would like for these created queues to be hidden from the user except in the Web UI. Some comments on the patch: # AbstractReservationSystem: Can remove the following comment. {code} // currently only capacity scheduler is supported {code} # Spurious changes that reorder imports # FairReservationSystem: LOG is not used anywhere. Can we remove that and the corresponding imports. Also, I don't think we arrived at a decision to use slf4j yet. We should use the commons-logging Log instead. # ReservationSystemTestUtil: The newly added methods should have FS somewhere in the name for clarity. > Add FairReservationSystem for FairScheduler > ------------------------------------------- > > Key: YARN-2738 > URL: https://issues.apache.org/jira/browse/YARN-2738 > Project: Hadoop YARN > Issue Type: Sub-task > Components: fairscheduler > Reporter: Anubhav Dhoot > Assignee: Anubhav Dhoot > Attachments: YARN-2738.001.patch, YARN-2738.002.patch, > YARN-2738.003.patch > > > Need to create a FairReservationSystem that will implement ReservationSystem > for FairScheduler -- This message was sent by Atlassian JIRA (v6.3.4#6332)