[
https://issues.apache.org/jira/browse/YARN-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14231717#comment-14231717
]
Junping Du commented on YARN-1156:
----------------------------------
Thanks [~ozawa] for updating the patch! The patch looks good to me in overall.
IMO, one thing we can improve here is: for AllocatedGB, I think Math.ceil()
should be fine. However, for AvailableGB, it seems safer to use Math.floor().
It bring much more chance for AllocatedGB + AvailableGB = Total Capacity (if
total capacity is an integer). Thoughts?
> Change NodeManager AllocatedGB and AvailableGB metrics to show decimal values
> -----------------------------------------------------------------------------
>
> Key: YARN-1156
> URL: https://issues.apache.org/jira/browse/YARN-1156
> Project: Hadoop YARN
> Issue Type: Improvement
> Affects Versions: 2.1.0-beta
> Reporter: Akira AJISAKA
> Assignee: Tsuyoshi OZAWA
> Priority: Minor
> Labels: metrics, newbie
> Fix For: 2.7.0
>
> Attachments: YARN-1156.1.patch, YARN-1156.2.patch, YARN-1156.3.patch,
> YARN-1156.4.patch
>
>
> AllocatedGB and AvailableGB metrics are now integer type. If there are four
> times 500MB memory allocation to container, AllocatedGB is incremented four
> times by {{(int)500/1024}}, which means 0. That is, the memory size allocated
> is actually 2000MB, but the metrics shows 0GB. Let's use float type for these
> metrics.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
