[ https://issues.apache.org/jira/browse/YARN-2675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14254307#comment-14254307 ]
Karthik Kambatla commented on YARN-2675: ---------------------------------------- The latest patch looks good, the findbugs warnings look unrelated. +1. Checking this in. > the containersKilled metrics is not updated when the container is killed > during localization. > --------------------------------------------------------------------------------------------- > > Key: YARN-2675 > URL: https://issues.apache.org/jira/browse/YARN-2675 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Affects Versions: 2.5.0 > Reporter: zhihai xu > Assignee: zhihai xu > Labels: metrics, supportability > Attachments: YARN-2675.000.patch, YARN-2675.001.patch, > YARN-2675.002.patch, YARN-2675.003.patch, YARN-2675.004.patch, > YARN-2675.005.patch, YARN-2675.006.patch > > > The containersKilled metrics is not updated when the container is killed > during localization. We should add KILLING state in finished of > ContainerImpl.java to update killedContainer. -- This message was sent by Atlassian JIRA (v6.3.4#6332)