[
https://issues.apache.org/jira/browse/YARN-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260496#comment-14260496
]
Hadoop QA commented on YARN-2936:
---------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12689373/YARN-2936.004.patch
against trunk revision 249cc90.
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/6204//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6204//console
This message is automatically generated.
> YARNDelegationTokenIdentifier doesn't set proto.builder now
> -----------------------------------------------------------
>
> Key: YARN-2936
> URL: https://issues.apache.org/jira/browse/YARN-2936
> Project: Hadoop YARN
> Issue Type: Bug
> Reporter: Zhijie Shen
> Assignee: Varun Saxena
> Attachments: YARN-2936.001.patch, YARN-2936.002.patch,
> YARN-2936.003.patch, YARN-2936.004.patch, YARN-2936.005.patch
>
>
> After YARN-2743, the setters are removed from YARNDelegationTokenIdentifier,
> such that when constructing a object which extends
> YARNDelegationTokenIdentifier, proto.builder is not set at all. Later on,
> when we call getProto() of it, we will just get an empty proto object.
> It seems to do no harm to the production code path, as we will always call
> getBytes() before using proto to persist the DT in the state store, when we
> generating the password.
> I think the setter is removed to avoid duplicating setting the fields why
> getBytes() is called. However, YARNDelegationTokenIdentifier doesn't work
> properly alone. YARNDelegationTokenIdentifier is tightly coupled with the
> logic in secretManager. It's vulnerable if something is changed at
> secretManager. For example, in the test case of YARN-2837, I spent time to
> figure out we need to execute getBytes() first to make sure the testing DTs
> can be properly put into the state store.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
