[ 
https://issues.apache.org/jira/browse/YARN-3029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14273845#comment-14273845
 ] 

Hadoop QA commented on YARN-3029:
---------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12691673/YARN-3029.001.patch
  against trunk revision 5b0d060.

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/6309//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6309//console

This message is automatically generated.

> FSDownload.unpack() uses local locale for FS case conversion, may not work 
> everywhere
> -------------------------------------------------------------------------------------
>
>                 Key: YARN-3029
>                 URL: https://issues.apache.org/jira/browse/YARN-3029
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: nodemanager
>    Affects Versions: 2.6.0
>            Reporter: Steve Loughran
>            Assignee: Varun Saxena
>         Attachments: YARN-3029.001.patch
>
>
> {{FSDownload.unpack()}} lower-cases filenames in the local locale before 
> looking at extensions for, "tar, "zip", ..
> {code}
> String lowerDst = dst.getName().toLowerCase();
> {code}
> it MUST use LOCALE_EN for the locale, else a file .ZIP won't be recognised as 
> a zipfile in a turkish locale cluster



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to