[ https://issues.apache.org/jira/browse/YARN-3144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309585#comment-14309585 ]
Jason Lowe commented on YARN-3144: ---------------------------------- Thanks, Jon! We're almost there, but on the final review before commit I found one last thing that I think should be fixed. My apologies for not catching it sooner: {code} + } catch (Exception e ) { + if (timelineServiceBestEffort) { + LOG.warn("Failed to get delegation token from the timeline server"); + return null; + } {code} I think it's important to log something about the exception that was received, otherwise it can be very frustrating to debug. Not sure if we should log the full exception stack or just the message, but I think we should say more than just it didn't work. > Configuration for making delegation token failures to timeline server > not-fatal > ------------------------------------------------------------------------------- > > Key: YARN-3144 > URL: https://issues.apache.org/jira/browse/YARN-3144 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: Jonathan Eagles > Assignee: Jonathan Eagles > Attachments: YARN-3144.1.patch, YARN-3144.2.patch, YARN-3144.3.patch > > > Posting events to the timeline server is best-effort. However, getting the > delegation tokens from the timeline server will kill the job. This patch adds > a configuration to make get delegation token operations "best-effort". -- This message was sent by Atlassian JIRA (v6.3.4#6332)