[ 
https://issues.apache.org/jira/browse/YARN-3034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14314797#comment-14314797
 ] 

Sangjin Lee commented on YARN-3034:
-----------------------------------

Some feedback on the patch...

(1) this creates a dependency from RM to the timeline service; perhaps it is 
unavoidable...
(2) RMTimelineAggregator.java
- we need the license
- annotate with @Private and @Unstable
- line. 31: nit; spacing

(3) SystemMetricsPublisher.java
- instead of replacing the use of the existing ATS, I think we need to have 
both (the existing ATS calls as well as the new calls); we will need a global 
config that enables/disables the next gen timeline service


> implement RM starting its ATS writer
> ------------------------------------
>
>                 Key: YARN-3034
>                 URL: https://issues.apache.org/jira/browse/YARN-3034
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Naganarasimha G R
>         Attachments: YARN-3034.20150205-1.patch
>
>
> Per design in YARN-2928, implement resource managers starting their own ATS 
> writers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to