[ 
https://issues.apache.org/jira/browse/YARN-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14346477#comment-14346477
 ] 

Robert Kanter commented on YARN-3264:
-------------------------------------

In addition to the things Zhijie said,

11. It would be good to refactor this to have the {{close}} in a finally block 
in case an Exception occurs we can clean up.
{code}
112           PrintWriter out = new PrintWriter(new BufferedWriter(new 
FileWriter(
113               fileName, true)));
114           out.println(TimelineUtils.dumpTimelineRecordtoJSON(entity));
115           out.write("\n");
116           out.close();
117         } catch (IOException ioe) {
{code}

> [Storage implementation] Create a POC only file based storage implementation 
> for ATS writes
> -------------------------------------------------------------------------------------------
>
>                 Key: YARN-3264
>                 URL: https://issues.apache.org/jira/browse/YARN-3264
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Vrushali C
>            Assignee: Vrushali C
>         Attachments: YARN-3264.001.patch, YARN-3264.002.patch
>
>
> For the PoC, need to create a backend impl for file based storage of entities 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to