[
https://issues.apache.org/jira/browse/YARN-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14369909#comment-14369909
]
Wangda Tan commented on YARN-2495:
----------------------------------
Hi [~Naganarasimha],
For 1)
I suggest to use a separated PB message, such as NodeLabelsProto (or make it
generic like StringArrayProto), which contains {{repeat string}}.
When using NodeIdToLabelsProto, but don't use nodeId, that will confuse people.
About test cases
1. NodeStatusUpdaterTest:
Some places need to cover:
- NM register, should check RTS (ResourceTrackerService) labels (done)
- NM heartheat, should check RTS labels (TODO)
- NM headtbeat without update, should check RTS received labels (TODO)
- NM heartbeat with update, should check RTS received labels (TODO)
2. TestResourceTrackerService
Test generally very good to me,
- lblsMgr -> nodeLabelsMgr or labelsMgr
> Allow admin specify labels from each NM (Distributed configuration)
> -------------------------------------------------------------------
>
> Key: YARN-2495
> URL: https://issues.apache.org/jira/browse/YARN-2495
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Reporter: Wangda Tan
> Assignee: Naganarasimha G R
> Attachments: YARN-2495.20141023-1.patch, YARN-2495.20141024-1.patch,
> YARN-2495.20141030-1.patch, YARN-2495.20141031-1.patch,
> YARN-2495.20141119-1.patch, YARN-2495.20141126-1.patch,
> YARN-2495.20141204-1.patch, YARN-2495.20141208-1.patch,
> YARN-2495.20150305-1.patch, YARN-2495.20150309-1.patch,
> YARN-2495.20150318-1.patch, YARN-2495_20141022.1.patch
>
>
> Target of this JIRA is to allow admin specify labels in each NM, this covers
> - User can set labels in each NM (by setting yarn-site.xml (YARN-2923) or
> using script suggested by [~aw] (YARN-2729) )
> - NM will send labels to RM via ResourceTracker API
> - RM will set labels in NodeLabelManager when NM register/update labels
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
