[ 
https://issues.apache.org/jira/browse/YARN-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14494377#comment-14494377
 ] 

Rohith commented on YARN-3225:
------------------------------

Thanks [~devaraj.k] for patch and [~djp] for review.
Overall approach and patch looks good to me. One suggestion on the patch is 
DecommissionType#FORCEFUL java doc is bit confusing. {{Forceful decommissioning 
of nodes}} Since FORCEFUL type is applied only on the nodes which are 
*decommissioning* state, RUNNING state nodes can not be forcefully 
decommissioned.

> New parameter or CLI for decommissioning node gracefully in RMAdmin CLI
> -----------------------------------------------------------------------
>
>                 Key: YARN-3225
>                 URL: https://issues.apache.org/jira/browse/YARN-3225
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Junping Du
>            Assignee: Devaraj K
>         Attachments: YARN-3225-1.patch, YARN-3225-2.patch, YARN-3225-3.patch, 
> YARN-3225-4.patch, YARN-3225.patch, YARN-914.patch
>
>
> New CLI (or existing CLI with parameters) should put each node on 
> decommission list to decommissioning status and track timeout to terminate 
> the nodes that haven't get finished.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to