[ 
https://issues.apache.org/jira/browse/YARN-3046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504118#comment-14504118
 ] 

Sangjin Lee commented on YARN-3046:
-----------------------------------

Looks fine for the most part. One small point:

(JobHistoryEventHandler.java)
- l.851: OK, this is another existing bug :) I'll leave it up to you to decide 
whether we want to fix this in ATS v.1 in a separate JIRA

(JobFinishedEvent.java)
- l.150: same issue


> [Event producers] Implement MapReduce AM writing MR events to v2 ATS
> --------------------------------------------------------------------
>
>                 Key: YARN-3046
>                 URL: https://issues.apache.org/jira/browse/YARN-3046
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>            Reporter: Sangjin Lee
>            Assignee: Junping Du
>         Attachments: YARN-3046-no-test-v2.patch, YARN-3046-no-test.patch, 
> YARN-3046-v1-rebase.patch, YARN-3046-v1.patch, YARN-3046-v2.patch, 
> YARN-3046-v3.patch, YARN-3046-v4.patch, YARN-3046-v5.patch
>
>
> Per design in YARN-2928, select a handful of MR metrics (e.g. HDFS bytes 
> written) and have the MR AM write the framework-specific metrics to ATS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to