[
https://issues.apache.org/jira/browse/YARN-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steve Loughran updated YARN-3477:
---------------------------------
Attachment: YARN-3477-002.patch
YARN-3477 patch 002
# rethrowing runtime exception on timeout, but including the IOE as an inner
exception
# using constant strings in the error messages
# clean up tests to (a) use those constant strings in tests, (b) throw the
original exception on any mismatch, plus other improvements
moving back to an RTE is consistent, but makes it harder for callers to
distinguish events like ConnectionRefused from other things.
I would prefer the (incompatible) change of patch 001, speaking as one of the
few people who have written an ATS client. Alternatively, define a specific RTE
of "TimelineRetryTimeout" which apps can filter on -including these tests
> TimelineClientImpl swallows exceptions
> --------------------------------------
>
> Key: YARN-3477
> URL: https://issues.apache.org/jira/browse/YARN-3477
> Project: Hadoop YARN
> Issue Type: Bug
> Components: timelineserver
> Affects Versions: 2.6.0, 2.7.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: YARN-3477-001.patch, YARN-3477-002.patch
>
>
> If timeline client fails more than the retry count, the original exception is
> not thrown. Instead some runtime exception is raised saying "retries run out"
> # the failing exception should be rethrown, ideally via
> NetUtils.wrapException to include URL of the failing endpoing
> # Otherwise, the raised RTE should (a) state that URL and (b) set the
> original fault as the inner cause
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
