[
https://issues.apache.org/jira/browse/YARN-3431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14511104#comment-14511104
]
Junping Du commented on YARN-3431:
----------------------------------
bq. I'm still not sure if it's good idea to expose two TimelineUtils to users.
I already gave my points why we cannot merge two TimelineUtils (for dependency
issues). It is very nature that if we want to abstract some methods in yarn-api
for timeline service, we can put the one in yarn-api; similar use case for
yarn-common one. What's your concern to have Utility class in different
component/project?
bq. And this jira shouldn't depend on YARN-3276, right?
Yes. But this patch could make YARN-3276 get rebased again which has pending
for a long time. I gave the comments long ago when reviewing YARN-3087
(https://issues.apache.org/jira/browse/YARN-3087?focusedCommentId=14339015&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14339015),
but that comments get ignored. So instead, I filed a JIRA to fix this in
YARN-3276. I strongly like YARN-3276 to go first.
> Sub resources of timeline entity needs to be passed to a separate endpoint.
> ---------------------------------------------------------------------------
>
> Key: YARN-3431
> URL: https://issues.apache.org/jira/browse/YARN-3431
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Zhijie Shen
> Assignee: Zhijie Shen
> Attachments: YARN-3431.1.patch, YARN-3431.2.patch, YARN-3431.3.patch,
> YARN-3431.4.patch, YARN-3431.5.patch, YARN-3431.6.patch
>
>
> We have TimelineEntity and some other entities as subclass that inherit from
> it. However, we only have a single endpoint, which consume TimelineEntity
> rather than sub-classes and this endpoint will check the incoming request
> body contains exactly TimelineEntity object. However, the json data which is
> serialized from sub-class object seems not to be treated as an TimelineEntity
> object, and won't be deserialized into the corresponding sub-class object
> which cause deserialization failure as some discussions in YARN-3334 :
> https://issues.apache.org/jira/browse/YARN-3334?focusedCommentId=14391059&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14391059.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
