[ https://issues.apache.org/jira/browse/YARN-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518222#comment-14518222 ]
Sandy Ryza commented on YARN-3485: ---------------------------------- One nit: {code} + return Math.min( Math.min(value1, value2), value3); {code} has an extra space. Otherwise +1. > FairScheduler headroom calculation doesn't consider maxResources for Fifo and > FairShare policies > ------------------------------------------------------------------------------------------------ > > Key: YARN-3485 > URL: https://issues.apache.org/jira/browse/YARN-3485 > Project: Hadoop YARN > Issue Type: Bug > Components: fairscheduler > Affects Versions: 2.7.0 > Reporter: Karthik Kambatla > Assignee: Karthik Kambatla > Priority: Critical > Attachments: yarn-3485-1.patch, yarn-3485-2.patch, > yarn-3485-prelim.patch > > > FairScheduler's headroom calculations consider the fairshare and > cluster-available-resources, and the fairshare has maxResources. However, for > Fifo and Fairshare policies, the fairshare is used only for memory and not > cpu. So, the scheduler ends up showing a higher headroom than is actually > available. This could lead to applications waiting for resources far longer > than then intend to. e.g. MAPREDUCE-6302. -- This message was sent by Atlassian JIRA (v6.3.4#6332)