[ 
https://issues.apache.org/jira/browse/YARN-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518538#comment-14518538
 ] 

zhihai xu commented on YARN-3363:
---------------------------------

It looks like the checkstyle issues are not related to my change.
I checked the code at the lines shown in the following logs: I didn't see any 
checkstyle issues,
{code}
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainerStartMonitoringEvent.java
   19      29
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/monitor/ContainerMetrics.java
        82      92
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/container/ContainerImpl.java
 221     223
{code}
So it looks like there may be some problems in the checkstyle script.

> add localization and container launch time to ContainerMetrics at NM to show 
> these timing information for each active container.
> --------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3363
>                 URL: https://issues.apache.org/jira/browse/YARN-3363
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: nodemanager
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>              Labels: metrics, supportability
>         Attachments: YARN-3363.000.patch, YARN-3363.001.patch
>
>
> add localization and container launch time to ContainerMetrics at NM to show 
> these timing information for each active container.
> Currently ContainerMetrics has container's actual memory usage(YARN-2984),  
> actual CPU usage(YARN-3122), resource  and pid(YARN-3022). It will be better 
> to have localization and container launch time in ContainerMetrics for each 
> active container.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to