[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14518760#comment-14518760
]
Sangjin Lee commented on YARN-3044:
-----------------------------------
It looks like some of the issues reported by the jenkins build might be related
to the patch? It would be great if you could look into them and see if we can
resolve them.
Some additional comments:
(RMContainerEntity.java)
- l.28-29: NM -> RM
(TimelineServiceV2Publisher.java)
- l.141: I would prefer explicit entity.setQueue() over setting the info
directly. Although it is currently equivalent, we should stick with the high
level methods we introduced and that would be robust even if we should change
how the queue is set.
- l.147: how about using a simple for loop?
- l.179: curious, we could add them to the entity as metrics, right?
- l.300: unnecessary line?
> [Event producers] Implement RM writing app lifecycle events to ATS
> ------------------------------------------------------------------
>
> Key: YARN-3044
> URL: https://issues.apache.org/jira/browse/YARN-3044
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Sangjin Lee
> Assignee: Naganarasimha G R
> Attachments: YARN-3044-YARN-2928.004.patch,
> YARN-3044.20150325-1.patch, YARN-3044.20150406-1.patch,
> YARN-3044.20150416-1.patch
>
>
> Per design in YARN-2928, implement RM writing app lifecycle events to ATS.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
