[ https://issues.apache.org/jira/browse/YARN-1967?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14524119#comment-14524119 ]
Xuan Gong commented on YARN-1967: --------------------------------- [~ozawa] Do we really need this ? Looks like we have handle it on HeartbeatThread. For the CallbackHandler, I think that this is used for handling the response. So, probably no need for callbackHandler. > onShutdownRequest() is not called when > AMRMClientAsyncImpl#unregisterApplicationMaster() is called > -------------------------------------------------------------------------------------------------- > > Key: YARN-1967 > URL: https://issues.apache.org/jira/browse/YARN-1967 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Tsuyoshi Ozawa > Attachments: YARN-1967.1.patch > > > When I taking on YARN-1954, I found that onShutdownRequest() is not called > when AMRMClientAsyncImpl#unregisterApplicationMaster() is called. > Should we fix it by calling onShutdownRequest() or adding new > hook(onUnregisteredApplicationRequest) to CallbackHandler? -- This message was sent by Atlassian JIRA (v6.3.4#6332)