[ 
https://issues.apache.org/jira/browse/YARN-3562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14530710#comment-14530710
 ] 

Junping Du commented on YARN-3562:
----------------------------------

I didn't see anything to do with release audit, as 16 files without Apache 
Header belongs to patchprocess:
{code}
 !????? patchprocess/patchJavacWarnings.txt
 !????? patchprocess/jira
 !????? patchprocess/YARN-2928JavacWarnings.txt
 !????? patchprocess/YARN-2928checkstylehadoop-yarn-server-resourcemanager.txt
 !????? patchprocess/patch
 !????? patchprocess/YARN-2928checkstylehadoop-yarn-server-timelineservice.txt
 !????? 
patchprocess/maven-YARN-2928checkstyle-hadoop-yarn-server-resourcemanager.txt
 !????? patchprocess/YARN-2928checkstylehadoop-yarn-server-tests.txt
 !????? patchprocess/gitdifflines.txt
 !????? patchprocess/patchJavadocWarnings.txt
 !????? patchprocess/filteredPatchJavacWarnings.txt
 !????? patchprocess/patchReleaseAuditOutput.txt
 !????? 
patchprocess/maven-YARN-2928checkstyle-hadoop-yarn-server-timelineservice.txt
 !????? patchprocess/filteredYARN-2928JavacWarnings.txt
 !????? patchprocess/maven-YARN-2928checkstyle-hadoop-yarn-server-tests.txt
 !????? patchprocess/YARN-2928JavadocWarnings.txt
Lines that start with ????? in the release audit  report indicate files that do 
not have an Apache license header.
{code}
However, we should address the checkstyle warning below:
{code}
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/storage/FileSystemTimelineWriterImpl.java:24:8:
 Unused import - java.io.FileWriter.
{code}

Other looks good to me.

> unit tests failures and issues found from findbug from earlier ATS checkins
> ---------------------------------------------------------------------------
>
>                 Key: YARN-3562
>                 URL: https://issues.apache.org/jira/browse/YARN-3562
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Naganarasimha G R
>            Priority: Minor
>              Labels: BB2015-05-TBR
>         Attachments: YARN-3562-YARN-2928.001.patch, 
> YARN-3562-YARN-2928.002.patch
>
>
> *Issues reported from MAPREDUCE-6337* :
> A bunch of MR unit tests are failing on our branch whenever the mini YARN 
> cluster needs to bring up multiple node managers.
> For example, see 
> https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/5472/testReport/org.apache.hadoop.mapred/TestClusterMapReduceTestCase/testMapReduceRestarting/
> It is because the NMCollectorService is using a fixed port for the RPC (8048).
> *Issues reported from YARN-3044* :
> Test case failures and tools(FB & CS) issues found :
> # find bugs issue : Comparison of String objects using == or != in 
> ResourceTrackerService.updateAppCollectorsMap
> # find bugs issue : Boxing/unboxing to parse a primitive 
> RMTimelineCollectorManager.postPut. Called method Long.longValue()
> Should call Long.parseLong(String) instead.
> # find bugs issue : DM_DEFAULT_ENCODING Called method new 
> java.io.FileWriter(String, boolean) At 
> FileSystemTimelineWriterImpl.java:\[line 86\]
> # hadoop.yarn.server.resourcemanager.TestAppManager, 
> hadoop.yarn.server.resourcemanager.rmapp.TestRMAppTransitions, 
> hadoop.yarn.server.resourcemanager.TestClientRMService & 
> hadoop.yarn.server.resourcemanager.logaggregationstatus.TestRMAppLogAggregationStatus,
>  refer https://builds.apache.org/job/PreCommit-YARN-Build/7534/testReport/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to