[ https://issues.apache.org/jira/browse/YARN-2918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533329#comment-14533329 ]
Hadoop QA commented on YARN-2918: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 14m 35s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 2 new or modified test files. | | {color:green}+1{color} | javac | 7m 29s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 32s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 0m 47s | The applied patch generated 5 new checkstyle issues (total was 363, now 367). | | {color:red}-1{color} | whitespace | 0m 12s | The patch has 28 line(s) that end in whitespace. Use git apply --whitespace=fix. | | {color:green}+1{color} | install | 1m 36s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 15s | The patch does not introduce any new Findbugs (version 2.0.3) warnings. | | {color:green}+1{color} | yarn tests | 52m 56s | Tests passed in hadoop-yarn-server-resourcemanager. | | | | 89m 22s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12731243/YARN-2918.3.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / ab5058d | | checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/7772/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt | | whitespace | https://builds.apache.org/job/PreCommit-YARN-Build/7772/artifact/patchprocess/whitespace.txt | | hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/7772/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/7772/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/7772/console | This message was automatically generated. > Don't fail RM if queue's configured labels are not existed in > cluster-node-labels > --------------------------------------------------------------------------------- > > Key: YARN-2918 > URL: https://issues.apache.org/jira/browse/YARN-2918 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Rohith > Assignee: Wangda Tan > Labels: BB2015-05-TBR > Attachments: YARN-2918.1.patch, YARN-2918.2.patch, YARN-2918.3.patch > > > Currently, if admin setup labels on queues > {{<queue-path>.accessible-node-labels = ...}}. And the label is not added to > RM, queue's initialization will fail and RM will fail too: > {noformat} > 2014-12-03 20:11:50,126 FATAL > org.apache.hadoop.yarn.server.resourcemanager.ResourceManager: Error starting > ResourceManager > ... > Caused by: java.io.IOException: NodeLabelManager doesn't include label = x, > please check. > at > org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils.checkIfLabelInClusterNodeLabels(SchedulerUtils.java:287) > at > org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractCSQueue.<init>(AbstractCSQueue.java:109) > at > org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue.<init>(LeafQueue.java:120) > at > org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler.parseQueue(CapacityScheduler.java:567) > at > org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler.parseQueue(CapacityScheduler.java:587) > at > org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler.initializeQueues(CapacityScheduler.java:462) > at > org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler.initScheduler(CapacityScheduler.java:294) > at > org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler.serviceInit(CapacityScheduler.java:324) > at > org.apache.hadoop.service.AbstractService.init(AbstractService.java:163) > {noformat} > This is not a good user experience, we should stop fail RM so that admin can > configure queue/labels in following steps: > - Configure queue (with label) > - Start RM > - Add labels to RM > - Submit applications > Now admin has to: > - Configure queue (without label) > - Start RM > - Add labels to RM > - Refresh queue's config (with label) > - Submit applications -- This message was sent by Atlassian JIRA (v6.3.4#6332)