[ https://issues.apache.org/jira/browse/YARN-3484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14534877#comment-14534877 ]
Allen Wittenauer commented on YARN-3484: ---------------------------------------- * Some shellcheck errors: {code} hadoop-yarn-project/hadoop-yarn/bin/yarn:65:13: warning: Declare and assign separately to avoid masking return values. [SC2155] hadoop-yarn-project/hadoop-yarn/bin/yarn:72:13: warning: Declare and assign separately to avoid masking return values. [SC2155] {code} * If the RM isn't up, we throw an exception. * tput stderr needs to be /dev/null'd > Fix up yarn top shell code > -------------------------- > > Key: YARN-3484 > URL: https://issues.apache.org/jira/browse/YARN-3484 > Project: Hadoop YARN > Issue Type: Bug > Components: scripts > Affects Versions: 3.0.0 > Reporter: Allen Wittenauer > Assignee: Varun Vasudev > Labels: BB2015-05-TBR, newbie > Attachments: YARN-3484.001.patch, YARN-3484.002.patch > > > We need to do some work on yarn top's shell code. > a) Just checking for TERM isn't good enough. We really need to check the > return on tput, especially since the output will not be a number but an error > string which will likely blow up the java code in horrible ways. > b) All the single bracket tests should be double brackets to force the bash > built-in. > c) I'd think I'd rather see the shell portion in a function since it's rather > large. This will allow for args, etc, to get local'ized and clean up the > case statement. -- This message was sent by Atlassian JIRA (v6.3.4#6332)