[
https://issues.apache.org/jira/browse/YARN-3276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14536177#comment-14536177
]
Zhijie Shen commented on YARN-3276:
-----------------------------------
Some comments about the latest patch.
1. TimelineServiceUtils -> TimelineServiceHelper?
2. Is mapreduce using it? Maybe simply \@Private
{code}
26 @LimitedPrivate({ "MapReduce", "YARN" })
27 public final class TimelineServiceUtils {
{code}
3. TimelineEvent are not covered?
4. AllocateResponsePBImpl change is not related?
> Refactor and fix null casting in some map cast for TimelineEntity (old and
> new) and fix findbug warnings
> --------------------------------------------------------------------------------------------------------
>
> Key: YARN-3276
> URL: https://issues.apache.org/jira/browse/YARN-3276
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Junping Du
> Assignee: Junping Du
> Attachments: YARN-3276-YARN-2928.v3.patch,
> YARN-3276-YARN-2928.v4.patch, YARN-3276-v2.patch, YARN-3276-v3.patch,
> YARN-3276.patch
>
>
> Per discussion in YARN-3087, we need to refactor some similar logic to cast
> map to hashmap and get rid of NPE issue.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
