[
https://issues.apache.org/jira/browse/YARN-3579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540919#comment-14540919
]
Wangda Tan commented on YARN-3579:
----------------------------------
[~sunilg],
Thanks for updating, few comments:
1) Following methods can be private:
generateNodeLabelsInfoPerNode/getLabelsToNodesMapping/getLabelsByNode/getLabelsByNode/getLabelsInfoByNode
2) getLabelsInfoByNode can use getLabelsByNode result and get labelsInfo.
3) findBugs warning?
> getLabelsToNodes in CommonNodeLabelsManager should support NodeLabel instead
> of label name as String
> ----------------------------------------------------------------------------------------------------
>
> Key: YARN-3579
> URL: https://issues.apache.org/jira/browse/YARN-3579
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: resourcemanager
> Affects Versions: 2.6.0
> Reporter: Sunil G
> Assignee: Sunil G
> Priority: Minor
> Attachments: 0001-YARN-3579.patch, 0002-YARN-3579.patch
>
>
> CommonNodeLabelsManager#getLabelsToNodes returns label name as string. It is
> not passing information such as Exclusivity etc back to REST interface apis.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
