[ https://issues.apache.org/jira/browse/YARN-3632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14549460#comment-14549460 ]
Jian He commented on YARN-3632: ------------------------------- - the current reorder implementation in containerReleased and containerAllocated is triggered by every single container completed or allocated. This results in time complexity of {code} (#containersCompleted + #containersReleased)* #appsOnNode * log(#appsInQueue) {code} on every node heartbeat, we can improve this by reordering the app after processing all containers of the app to get rid of the first {code} (#containersCompleted + #containersReleased) {code} overhead. - this null check is not needed, if it can never be null; {code} if (updateDemandForQueue != null) { {code} > Ordering policy should be allowed to reorder an application when demand > changes > ------------------------------------------------------------------------------- > > Key: YARN-3632 > URL: https://issues.apache.org/jira/browse/YARN-3632 > Project: Hadoop YARN > Issue Type: Sub-task > Components: capacityscheduler > Reporter: Craig Welch > Assignee: Craig Welch > Attachments: YARN-3632.0.patch, YARN-3632.1.patch, YARN-3632.3.patch, > YARN-3632.4.patch, YARN-3632.5.patch > > > At present, ordering policies have the option to have an application > re-ordered (for allocation and preemption) when it is allocated to or a > container is recovered from the application. Some ordering policies may also > need to reorder when demand changes if that is part of the ordering > comparison, this needs to be made available (and used by the > fairorderingpolicy when sizebasedweight is true) -- This message was sent by Atlassian JIRA (v6.3.4#6332)