[ 
https://issues.apache.org/jira/browse/YARN-3684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551403#comment-14551403
 ] 

Sidharta Seethana commented on YARN-3684:
-----------------------------------------

* Checkstyle rules - the issues reported aren't real issues, IMO - see : 
HADOOP-11869
* findbugs failures - these are minor (unused local variables). This check 
succeeded on my Mac . Filed a bug : HADOOP-12002

I'll upload a new patch with the findbugs issues fixed.

> Change ContainerExecutor's primary lifecycle methods to use a more extensible 
> mechanism for passing information. 
> -----------------------------------------------------------------------------------------------------------------
>
>                 Key: YARN-3684
>                 URL: https://issues.apache.org/jira/browse/YARN-3684
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: yarn
>            Reporter: Sidharta Seethana
>            Assignee: Sidharta Seethana
>         Attachments: YARN-3648.001.patch
>
>
> As per description in parent JIRA :  Adding additional arguments to key 
> ContainerExecutor methods ( e.g startLocalizer or launchContainer ) would 
> break the existing ContainerExecutor interface and would require changes to 
> all executor implementations in YARN. In order to make this interface less 
> brittle in the future, it would make sense to encapsulate arguments in some 
> kind of a ‘context’ object which could be modified/extended without breaking 
> the ContainerExecutor interface in the future.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to