[ https://issues.apache.org/jira/browse/YARN-3626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14558495#comment-14558495 ]
Chris Nauroth commented on YARN-3626: ------------------------------------- Hi Craig. This looks good to me. I have just one minor nitpick. I think the logic in {{ContainerLaunch}} for setting {{preferLocalizedJars}} could be simplified to this: {code} boolean preferLocalizedJars = Boolean.valueOf(classpathPrependDistCache); {code} {{Boolean#valueOf}} is null-safe. Thanks! > On Windows localized resources are not moved to the front of the classpath > when they should be > ---------------------------------------------------------------------------------------------- > > Key: YARN-3626 > URL: https://issues.apache.org/jira/browse/YARN-3626 > Project: Hadoop YARN > Issue Type: Bug > Components: yarn > Environment: Windows > Reporter: Craig Welch > Assignee: Craig Welch > Fix For: 2.7.1 > > Attachments: YARN-3626.0.patch, YARN-3626.11.patch, > YARN-3626.14.patch, YARN-3626.4.patch, YARN-3626.6.patch, YARN-3626.9.patch > > > In response to the mapreduce.job.user.classpath.first setting the classpath > is ordered differently so that localized resources will appear before system > classpath resources when tasks execute. On Windows this does not work > because the localized resources are not linked into their final location when > the classpath jar is created. To compensate for that localized jar resources > are added directly to the classpath generated for the jar rather than being > discovered from the localized directories. Unfortunately, they are always > appended to the classpath, and so are never preferred over system resources. -- This message was sent by Atlassian JIRA (v6.3.4#6332)