[
https://issues.apache.org/jira/browse/YARN-3044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14560416#comment-14560416
]
Zhijie Shen commented on YARN-3044:
-----------------------------------
Naga, sorry for late reply. The new patch looks much better to me, but I still
concern about the following change:
{code}
287 @Override
288 public Dispatcher getDispatcher() {
289 Dispatcher dispatcher = null;
290
291 if (publishContainerMetrics) {
292 dispatcher = super.getDispatcher();
293 } else {
294 // Normal dispatcher is sufficient if container metrics are not
required
295 // to be published
296 dispatcher = new AsyncDispatcher();
297 }
298 return dispatcher;
299 }
{code}
I think it's better to retain the multiple-dispatchers, which is more flexible
to fit for different scales. We can config to change how many threads we need.
Routing an event to one dispatcher takes constant time according to the current
multiple-dispatchers implementation. Thoughts?
> [Event producers] Implement RM writing app lifecycle events to ATS
> ------------------------------------------------------------------
>
> Key: YARN-3044
> URL: https://issues.apache.org/jira/browse/YARN-3044
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Sangjin Lee
> Assignee: Naganarasimha G R
> Attachments: YARN-3044-YARN-2928.004.patch,
> YARN-3044-YARN-2928.005.patch, YARN-3044-YARN-2928.006.patch,
> YARN-3044-YARN-2928.007.patch, YARN-3044-YARN-2928.008.patch,
> YARN-3044.20150325-1.patch, YARN-3044.20150406-1.patch,
> YARN-3044.20150416-1.patch
>
>
> Per design in YARN-2928, implement RM writing app lifecycle events to ATS.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
