[ https://issues.apache.org/jira/browse/YARN-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14568735#comment-14568735 ]
Hadoop QA commented on YARN-3749: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | pre-patch | 20m 3s | Pre-patch trunk compilation is healthy. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:green}+1{color} | tests included | 0m 0s | The patch appears to include 8 new or modified test files. | | {color:green}+1{color} | javac | 7m 34s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 9m 42s | There were no new javadoc warning messages. | | {color:green}+1{color} | release audit | 0m 22s | The applied patch does not increase the total number of release audit warnings. | | {color:red}-1{color} | checkstyle | 2m 17s | The applied patch generated 1 new checkstyle issues (total was 212, now 213). | | {color:green}+1{color} | whitespace | 0m 1s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 32s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 6m 5s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | yarn tests | 0m 22s | Tests passed in hadoop-yarn-api. | | {color:green}+1{color} | yarn tests | 6m 58s | Tests passed in hadoop-yarn-client. | | {color:green}+1{color} | yarn tests | 1m 57s | Tests passed in hadoop-yarn-common. | | {color:red}-1{color} | yarn tests | 60m 34s | Tests failed in hadoop-yarn-server-resourcemanager. | | {color:green}+1{color} | yarn tests | 1m 51s | Tests passed in hadoop-yarn-server-tests. | | | | 121m 2s | | \\ \\ || Reason || Tests || | Timed out tests | org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestNodeLabelContainerAllocation | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12736753/YARN-3749.7.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / 990078b | | checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/8163/artifact/patchprocess/diffcheckstylehadoop-yarn-api.txt | | hadoop-yarn-api test log | https://builds.apache.org/job/PreCommit-YARN-Build/8163/artifact/patchprocess/testrun_hadoop-yarn-api.txt | | hadoop-yarn-client test log | https://builds.apache.org/job/PreCommit-YARN-Build/8163/artifact/patchprocess/testrun_hadoop-yarn-client.txt | | hadoop-yarn-common test log | https://builds.apache.org/job/PreCommit-YARN-Build/8163/artifact/patchprocess/testrun_hadoop-yarn-common.txt | | hadoop-yarn-server-resourcemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/8163/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt | | hadoop-yarn-server-tests test log | https://builds.apache.org/job/PreCommit-YARN-Build/8163/artifact/patchprocess/testrun_hadoop-yarn-server-tests.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/8163/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/8163/console | This message was automatically generated. > We should make a copy of configuration when init MiniYARNCluster with > multiple RMs > ---------------------------------------------------------------------------------- > > Key: YARN-3749 > URL: https://issues.apache.org/jira/browse/YARN-3749 > Project: Hadoop YARN > Issue Type: Bug > Reporter: Chun Chen > Assignee: Chun Chen > Attachments: YARN-3749.2.patch, YARN-3749.3.patch, YARN-3749.4.patch, > YARN-3749.5.patch, YARN-3749.6.patch, YARN-3749.7.patch, YARN-3749.patch > > > When I was trying to write a test case for YARN-2674, I found DS client > trying to connect to both rm1 and rm2 with the same address 0.0.0.0:18032 > when RM failover. But I initially set > yarn.resourcemanager.address.rm1=0.0.0.0:18032, > yarn.resourcemanager.address.rm2=0.0.0.0:28032 After digging, I found it is > in ClientRMService where the value of yarn.resourcemanager.address.rm2 > changed to 0.0.0.0:18032. See the following code in ClientRMService: > {code} > clientBindAddress = conf.updateConnectAddr(YarnConfiguration.RM_BIND_HOST, > YarnConfiguration.RM_ADDRESS, > > YarnConfiguration.DEFAULT_RM_ADDRESS, > server.getListenerAddress()); > {code} > Since we use the same instance of configuration in rm1 and rm2 and init both > RM before we start both RM, we will change yarn.resourcemanager.ha.id to rm2 > during init of rm2 and yarn.resourcemanager.ha.id will become rm2 during > starting of rm1. > So I think it is safe to make a copy of configuration when init both of the > rm. -- This message was sent by Atlassian JIRA (v6.3.4#6332)