[
https://issues.apache.org/jira/browse/YARN-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14593532#comment-14593532
]
Chengbing Liu commented on YARN-3826:
-------------------------------------
[~devaraj.k], is it possible that two heartbeats happen at the same time?
Because the following code
{code}
shutDown.setDiagnosticsMessage(message);
return shutDown;
{code}
is not atomic, race can happen when two threads run to this point
simultaneously.
> Race condition in ResourceTrackerService: potential wrong diagnostics messages
> ------------------------------------------------------------------------------
>
> Key: YARN-3826
> URL: https://issues.apache.org/jira/browse/YARN-3826
> Project: Hadoop YARN
> Issue Type: Bug
> Components: resourcemanager
> Affects Versions: 2.7.0
> Reporter: Chengbing Liu
> Assignee: Chengbing Liu
> Attachments: YARN-3826.01.patch
>
>
> Since we are calling {{setDiagnosticsMessage}} in {{nodeHeartbeat}}, which
> can be called concurrently, the static {{resync}} and {{shutdown}} may have
> wrong diagnostics messages in some cases.
> On the other side, these static members can hardly save any memory, since the
> normal heartbeat responses are created for each heartbeat.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
