[ https://issues.apache.org/jira/browse/YARN-3850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14604166#comment-14604166 ]
Hudson commented on YARN-3850: ------------------------------ FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #230 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/230/]) YARN-3850. NM fails to read files from full disks which can lead to container logs being lost and other issues. Contributed by Varun Saxena (jlowe: rev 40b256949ad6f6e0dbdd248f2d257b05899f4332) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/AppLogAggregatorImpl.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/logaggregation/TestLogAggregationService.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/containermanager/launcher/RecoveredContainerLaunch.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/webapp/ContainerLogsUtils.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/LocalDirsHandlerService.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/test/java/org/apache/hadoop/yarn/server/nodemanager/webapp/TestContainerLogsPage.java > NM fails to read files from full disks which can lead to container logs being > lost and other issues > --------------------------------------------------------------------------------------------------- > > Key: YARN-3850 > URL: https://issues.apache.org/jira/browse/YARN-3850 > Project: Hadoop YARN > Issue Type: Bug > Components: log-aggregation, nodemanager > Affects Versions: 2.7.0 > Reporter: Varun Saxena > Assignee: Varun Saxena > Priority: Blocker > Fix For: 2.7.1 > > Attachments: YARN-3850.01.patch, YARN-3850.02.patch > > > *Container logs* can be lost if disk has become full(~90% full). > When application finishes, we upload logs after aggregation by calling > {{AppLogAggregatorImpl#uploadLogsForContainers}}. But this call in turns > checks the eligible directories on call to > {{LocalDirsHandlerService#getLogDirs}} which in case of disk full would > return nothing. So none of the container logs are aggregated and uploaded. > But on application finish, we also call > {{AppLogAggregatorImpl#doAppLogAggregationPostCleanUp()}}. This deletes the > application directory which contains container logs. This is because it calls > {{LocalDirsHandlerService#getLogDirsForCleanup}} which returns the full disks > as well. > So we are left with neither aggregated logs for the app nor the individual > container logs for the app. > In addition to this, there are 2 more issues : > # {{ContainerLogsUtil#getContainerLogDirs}} does not consider full disks so > NM will fail to serve up logs from full disks from its web interfaces. > # {{RecoveredContainerLaunch#locatePidFile}} also does not consider full > disks so it is possible that on container recovery, PID file is not found. -- This message was sent by Atlassian JIRA (v6.3.4#6332)