[ https://issues.apache.org/jira/browse/YARN-3882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612909#comment-14612909 ]
Xuan Gong commented on YARN-3882: --------------------------------- +1 LGTM. Pending Jenkins > AggregatedLogFormat should close aclScanner and ownerScanner after create > them. > ------------------------------------------------------------------------------- > > Key: YARN-3882 > URL: https://issues.apache.org/jira/browse/YARN-3882 > Project: Hadoop YARN > Issue Type: Bug > Components: nodemanager > Affects Versions: 2.7.0 > Reporter: zhihai xu > Assignee: zhihai xu > Priority: Minor > Attachments: YARN-3882.000.patch > > > AggregatedLogFormat should close aclScanner and ownerScanner after create > them. {{aclScanner}} and {{ownerScanner}} are created by createScanner in > {{getApplicationAcls}} and {{getApplicationOwner}} and are never closed. > {{TFile.Reader.Scanner}} implement java.io.Closeable. We should close them > after use them. -- This message was sent by Atlassian JIRA (v6.3.4#6332)