[
https://issues.apache.org/jira/browse/YARN-3047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14617553#comment-14617553
]
Zhijie Shen commented on YARN-3047:
-----------------------------------
It looks good to me overall, exception the config. Please let me know if I've
missed something: the new configuration name is and the old configuration
default value are used together. Why do we want the combination?
{code}
276 if (YarnConfiguration.useHttps(conf)) {
277 return
conf.get(YarnConfiguration.TIMELINE_READER_WEBAPP_HTTPS_ADDRESS,
278
YarnConfiguration.DEFAULT_TIMELINE_SERVICE_WEBAPP_HTTPS_ADDRESS);
279 } else {
280 return conf.get(YarnConfiguration.TIMELINE_READER_WEBAPP_ADDRESS,
281 YarnConfiguration.DEFAULT_TIMELINE_SERVICE_WEBAPP_ADDRESS);
282 }
{code}
Can't we just reuse the existing config "timeline_service_webapp" instead of
creating a new? In fact, user is bind of writer. They just know
timeline_service_webapp is where they can access the data.
> [Data Serving] Set up ATS reader with basic request serving structure and
> lifecycle
> -----------------------------------------------------------------------------------
>
> Key: YARN-3047
> URL: https://issues.apache.org/jira/browse/YARN-3047
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Sangjin Lee
> Assignee: Varun Saxena
> Attachments: Timeline_Reader(draft).pdf,
> YARN-3047-YARN-2928.08.patch, YARN-3047-YARN-2928.09.patch,
> YARN-3047-YARN-2928.10.patch, YARN-3047-YARN-2928.11.patch,
> YARN-3047-YARN-2928.12.patch, YARN-3047.001.patch, YARN-3047.003.patch,
> YARN-3047.005.patch, YARN-3047.006.patch, YARN-3047.007.patch,
> YARN-3047.02.patch, YARN-3047.04.patch
>
>
> Per design in YARN-2938, set up the ATS reader as a service and implement the
> basic structure as a service. It includes lifecycle management, request
> serving, and so on.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
