[
https://issues.apache.org/jira/browse/YARN-3908?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14622987#comment-14622987
]
Sangjin Lee commented on YARN-3908:
-----------------------------------
A couple of comments on the latest patch:
I find that essentially the event timestamp is stored in the same manner as a
metric timestamp. So the mechanism of retrieving the event timestamp is nearly
identical to {{ColumnPrefix.readTimeseriesResults()}}. The only restriction of
the previous version of that method is that it explicitly cast the values to
{{Number}}. In the patch I genericized the method to handle any value type.
Having said that, I recognize that reading an event using a method named
{{readTimeseriesResults()}} is rather awkward. But alternatives are not great
either. {{ColumnPrefix}} is an enum, and it is quite awkward to introduce a
method that is useful for only one value of that enum. Perhaps we could create
a static wrapper method to bridge that gap. Let me know what you think.
Finally, I find that we're still not persisting the metric types. I could be
wrong but it appears that all metrics are treated as time series when they are
stored. I'll see if it would be straightforward to implement that piece, but it
could be bit involved. How about capturing that in its own subtask?
> Bugs in HBaseTimelineWriterImpl
> -------------------------------
>
> Key: YARN-3908
> URL: https://issues.apache.org/jira/browse/YARN-3908
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Reporter: Zhijie Shen
> Assignee: Vrushali C
> Attachments: YARN-3908-YARN-2928.001.patch,
> YARN-3908-YARN-2928.002.patch
>
>
> 1. In HBaseTimelineWriterImpl, the info column family contains the basic
> fields of a timeline entity plus events. However, entity#info map is not
> stored at all.
> 2 event#timestamp is also not persisted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
