[ https://issues.apache.org/jira/browse/YARN-3877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14633399#comment-14633399 ]
Steve Loughran commented on YARN-3877: -------------------------------------- LGTM. Do you think the final client.close() should go in a finally clause? Or better in a java 7 try-with-resources clause {code} try{YarnClient client = new MockYarnClient()} { ... } {code} > YarnClientImpl.submitApplication swallows exceptions > ---------------------------------------------------- > > Key: YARN-3877 > URL: https://issues.apache.org/jira/browse/YARN-3877 > Project: Hadoop YARN > Issue Type: Improvement > Components: client > Affects Versions: 2.7.2 > Reporter: Steve Loughran > Assignee: Varun Saxena > Priority: Minor > Attachments: YARN-3877.01.patch, YARN-3877.02.patch > > > When {{YarnClientImpl.submitApplication}} spins waiting for the application > to be accepted, any interruption during its Sleep() calls are logged and > swallowed. > this makes it hard to interrupt the thread during shutdown. Really it should > throw some form of exception and let the caller deal with it. -- This message was sent by Atlassian JIRA (v6.3.4#6332)