[ 
https://issues.apache.org/jira/browse/YARN-3887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645448#comment-14645448
 ] 

Sunil G commented on YARN-3887:
-------------------------------

Thank you [~jianhe] for the comments. I will update a patch addressing the same.
[~rohithsharma] If I understood your comment correctly, we may get a scenario 
when RMStateStore is slow in processing events and RM restart happened. Hence 
priority will not be updated in state store.

{code}
  public synchronized void updateApplicationState(
      ApplicationStateData appState) {
    dispatcher.getEventHandler().handle(new RMStateUpdateAppEvent(appState));
  }
{code}
This api is using the event handler to process the new RMStateUpdate. As 
mentioned by you, If we see {{storeRMDelegationToken}}, it calls 
{{handleStoreEvent}} directly.

So to summarize, could we have a new api in RMStateStore as  follows
{code}
  public synchronized void updateApplicationStateSynchronizly(
      ApplicationStateData appState) {
    handleStoreEvent(new RMStateUpdateAppEvent(appState));
  }
{code}
and use it from scheduler to avoid this case. Thoughts?

> Support for changing Application priority during runtime
> --------------------------------------------------------
>
>                 Key: YARN-3887
>                 URL: https://issues.apache.org/jira/browse/YARN-3887
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: capacityscheduler, resourcemanager
>            Reporter: Sunil G
>            Assignee: Sunil G
>         Attachments: 0001-YARN-3887.patch, 0002-YARN-3887.patch
>
>
> After YARN-2003, adding support to change priority of an application after 
> submission. This ticket will handle the server side implementation for same.
> A new RMAppEvent will be created to handle this, and will be common for all 
> schedulers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to