[
https://issues.apache.org/jira/browse/YARN-3986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14679273#comment-14679273
]
Hadoop QA commented on YARN-3986:
---------------------------------
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 16m 17s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 44s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 41s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 21s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 0m 48s | The applied patch generated 2
new checkstyle issues (total was 52, now 53). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 20s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 27s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:red}-1{color} | yarn tests | 52m 30s | Tests failed in
hadoop-yarn-server-resourcemanager. |
| | | 90m 45s | |
\\
\\
|| Reason || Tests ||
| Failed unit tests |
hadoop.yarn.server.resourcemanager.scheduler.capacity.TestContainerAllocation |
| | hadoop.yarn.server.resourcemanager.TestRMAdminService |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12749476/YARN-3986.01.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 8f73bdd |
| checkstyle |
https://builds.apache.org/job/PreCommit-YARN-Build/8807/artifact/patchprocess/diffcheckstylehadoop-yarn-server-resourcemanager.txt
|
| hadoop-yarn-server-resourcemanager test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8807/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8807/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8807/console |
This message was automatically generated.
> getTransferredContainers in AbstractYarnScheduler should be present in
> YarnScheduler interface instead
> ------------------------------------------------------------------------------------------------------
>
> Key: YARN-3986
> URL: https://issues.apache.org/jira/browse/YARN-3986
> Project: Hadoop YARN
> Issue Type: Bug
> Components: scheduler
> Affects Versions: 2.7.0
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Attachments: YARN-3986.01.patch
>
>
> Currently getTransferredContainers is present in {{AbstractYarnScheduler}}.
> *But in ApplicationMasterService, while registering AM, we are calling this
> method by typecasting it to AbstractYarnScheduler, which is incorrect.*
> This method should be moved to YarnScheduler.
> Because if a custom scheduler is to be added, it will implement
> YarnScheduler, not AbstractYarnScheduler.
> As ApplicationMasterService is calling getTransferredContainers by
> typecasting it to AbstractYarnScheduler, it is imposing an indirect
> dependency on AbstractYarnScheduler for any pluggable custom scheduler.
> We can move the method to YarnScheduler and leave the definition in
> AbstractYarnScheduler as it is.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
