[ 
https://issues.apache.org/jira/browse/YARN-4014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695084#comment-14695084
 ] 

Rohith Sharma K S commented on YARN-4014:
-----------------------------------------

thanks Sunil G for the review.. 
bq. In ApplicationCLI, public static final String SET_PRIORITY = "setPriority";
Done, changed to updatePriority

bq. In future --appId can be used with other parameters also, correct?
Yes, Done

bq. updateApplicationPriority can throw NumberFormatException
Since exception is directly thrown back to client cli, I think this should be 
fine.

bq. ClientRMService.java has few commented code.
Yes , Since YARN-3887 was not committed, I was used that patch to compile but 
while uploading patch I commented for HadoopQA compilation. Now I have 
uncommented those lines.



> Support user cli interface in for Application Priority
> ------------------------------------------------------
>
>                 Key: YARN-4014
>                 URL: https://issues.apache.org/jira/browse/YARN-4014
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: client, resourcemanager
>            Reporter: Rohith Sharma K S
>            Assignee: Rohith Sharma K S
>         Attachments: 0001-YARN-4014-V1.patch, 0001-YARN-4014.patch
>
>
> Track the changes for user-RM client protocol i.e ApplicationClientProtocol 
> changes and discussions in this jira.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to