[
https://issues.apache.org/jira/browse/YARN-4074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14717257#comment-14717257
]
Junping Du commented on YARN-4074:
----------------------------------
Thanks for uploading a patch, [~sjlee0]! Sorry for coming late on this, but
have a critical question on TimelineReader interface:
bq. Currently I am not planning to add new flow-specific methods to the
TimelineReader interface.
If so , how to query lastest N records with existing getEntities() API?
Actually, I think we should refactor existing getEntities() API before things
get worse. It include too many parameters, and most of them are optional. This
is very un-handy, easily cause bug and very hard to extend in future.
Instead, we should define something like EntityFilter class to include most of
these optional fields (include time range, topN, info/config/metric
sub-filters, etc.) which also be extended easily for other filters in future.
Thoughts?
Still in walking through your POC patch, more comments come after.
> [timeline reader] implement support for querying for flows and flow runs
> ------------------------------------------------------------------------
>
> Key: YARN-4074
> URL: https://issues.apache.org/jira/browse/YARN-4074
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Sangjin Lee
> Assignee: Sangjin Lee
> Attachments: YARN-4074-YARN-2928.POC.001.patch
>
>
> Implement support for querying for flows and flow runs.
> We should be able to query for the most recent N flows, etc.
> This includes changes to the {{TimelineReader}} API if necessary, as well as
> implementation of the API.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
