[ 
https://issues.apache.org/jira/browse/YARN-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14804943#comment-14804943
 ] 

Naganarasimha G R commented on YARN-4044:
-----------------------------------------

Hi [~sunilg],
Thanks for updating the patch, few nits
# As discussed earlier, we are depending on one of the feature of HistoryServer 
to return the latest event. So it would be better to cover in our test case as, 
if there is break in that feature our testcase can catch it. i.e to add 
additional events modifying the queue / priority (may be one modification for 
queue and other for Priority). 
# ApplicationUpdatedEvent has overridden {{hashCode}} but not {{equals}}. In 
the first place do we require to over ride the hashcode method ?

> Running applications information changes such as movequeue is not published 
> to TimeLine server
> ----------------------------------------------------------------------------------------------
>
>                 Key: YARN-4044
>                 URL: https://issues.apache.org/jira/browse/YARN-4044
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager, timelineserver
>    Affects Versions: 2.7.0
>            Reporter: Sunil G
>            Assignee: Sunil G
>            Priority: Critical
>         Attachments: 0001-YARN-4044.patch, 0002-YARN-4044.patch, 
> 0003-YARN-4044.patch, 0004-YARN-4044.patch
>
>
> SystemMetricsPublisher need to expose an appUpdated api to update any change 
> for a running application.
> Events can be 
>       - change of queue for a running application.
>         - change of application priority for a running application.
> This ticket intends to handle both RM and timeline side changes. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to