[ 
https://issues.apache.org/jira/browse/YARN-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14939315#comment-14939315
 ] 

Joep Rottinghuis commented on YARN-4178:
----------------------------------------

Fine starting without it with benefit of more compact keys. If we add the 
application_ it should be post fixed in the key to ensure correct ordering.

Why do we need any util classes for this, can't an AppId class handle this by 
itself (convert from string to byte representation and back)?

Sent from my iPhone



> [storage implementation] app id as string in row keys can cause incorrect 
> ordering
> ----------------------------------------------------------------------------------
>
>                 Key: YARN-4178
>                 URL: https://issues.apache.org/jira/browse/YARN-4178
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: timelineserver
>    Affects Versions: YARN-2928
>            Reporter: Sangjin Lee
>            Assignee: Varun Saxena
>         Attachments: YARN-4178-YARN-2928.01.patch, 
> YARN-4178-YARN-2928.02.patch
>
>
> Currently the app id is used in various places as part of row keys. However, 
> currently they are treated as strings. This will cause a problem with 
> ordering when the id portion of the app id rolls over to the next digit.
> For example, "app_1234567890_10000" will be considered *earlier* than 
> "app_1234567890_9999". We should correct this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to