[ https://issues.apache.org/jira/browse/YARN-4253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952905#comment-14952905 ]
Hadoop QA commented on YARN-4253: --------------------------------- \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:red}-1{color} | pre-patch | 17m 16s | Pre-patch trunk has 1 extant Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | @author | 0m 0s | The patch does not contain any @author tags. | | {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | | {color:green}+1{color} | javac | 8m 16s | There were no new javac warning messages. | | {color:green}+1{color} | javadoc | 10m 41s | There were no new javadoc warning messages. | | {color:red}-1{color} | release audit | 0m 22s | The applied patch generated 1 release audit warnings. | | {color:red}-1{color} | checkstyle | 0m 39s | The applied patch generated 1 new checkstyle issues (total was 41, now 2). | | {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that end in whitespace. | | {color:green}+1{color} | install | 1m 44s | mvn install still works. | | {color:green}+1{color} | eclipse:eclipse | 0m 38s | The patch built with eclipse:eclipse. | | {color:green}+1{color} | findbugs | 1m 19s | The patch does not introduce any new Findbugs (version 3.0.0) warnings. | | {color:green}+1{color} | yarn tests | 9m 4s | Tests passed in hadoop-yarn-server-nodemanager. | | | | 50m 4s | | \\ \\ || Subsystem || Report/Notes || | Patch URL | http://issues.apache.org/jira/secure/attachment/12766085/YARN-4253.001.patch | | Optional Tests | javadoc javac unit findbugs checkstyle | | git revision | trunk / e617cf6 | | Pre-patch Findbugs warnings | https://builds.apache.org/job/PreCommit-YARN-Build/9406/artifact/patchprocess/trunkFindbugsWarningshadoop-yarn-server-nodemanager.html | | Release Audit | https://builds.apache.org/job/PreCommit-YARN-Build/9406/artifact/patchprocess/patchReleaseAuditProblems.txt | | checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/9406/artifact/patchprocess/diffcheckstylehadoop-yarn-server-nodemanager.txt | | hadoop-yarn-server-nodemanager test log | https://builds.apache.org/job/PreCommit-YARN-Build/9406/artifact/patchprocess/testrun_hadoop-yarn-server-nodemanager.txt | | Test Results | https://builds.apache.org/job/PreCommit-YARN-Build/9406/testReport/ | | Java | 1.7.0_55 | | uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux | | Console output | https://builds.apache.org/job/PreCommit-YARN-Build/9406/console | This message was automatically generated. > Standardize on using PrivilegedOperationExecutor for all invocations of > container-executor in LinuxContainerExecutor > -------------------------------------------------------------------------------------------------------------------- > > Key: YARN-4253 > URL: https://issues.apache.org/jira/browse/YARN-4253 > Project: Hadoop YARN > Issue Type: Improvement > Reporter: Sidharta Seethana > Assignee: Sidharta Seethana > Attachments: YARN-4253.001.patch > > > YARN-3443 introduced PrivilegedOperationExecutor and PrivilegedOperation(s) > which are meant to wrap invocations to the container-executor binary. > However, not all invocations of container-executor in LinuxContainerExecutor > use the PrivilegedOperationExecutor. We should change all such invocations to > use PrivilegedOperationExecutor. -- This message was sent by Atlassian JIRA (v6.3.4#6332)