[ https://issues.apache.org/jira/browse/YARN-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15026913#comment-15026913 ]
Junping Du commented on YARN-4386: ---------------------------------- Thanks [~kshukla] for the patch. I agree these test failures are not related. However, can we add a test to verify no InvalidState get throw after the patch if recommission a decommissioned node when calling refreshNodesGracefully()? That test should get failed without applying your code here. > refreshNodesGracefully() looks at active RMNode list for recommissioning > decommissioned nodes > --------------------------------------------------------------------------------------------- > > Key: YARN-4386 > URL: https://issues.apache.org/jira/browse/YARN-4386 > Project: Hadoop YARN > Issue Type: Bug > Components: graceful > Affects Versions: 3.0.0 > Reporter: Kuhu Shukla > Assignee: Kuhu Shukla > Priority: Minor > Attachments: YARN-4386-v1.patch > > > In refreshNodesGracefully(), during recommissioning, the entryset from > getRMNodes() which has only active nodes (RUNNING, DECOMMISSIONING etc.) is > used for checking 'decommissioned' nodes which are present in > getInactiveRMNodes() map alone. > {code} > for (Entry<NodeId, RMNode> entry:rmContext.getRMNodes().entrySet()) { > ......................... > // Recommissioning the nodes > if (entry.getValue().getState() == NodeState.DECOMMISSIONING > || entry.getValue().getState() == NodeState.DECOMMISSIONED) { > this.rmContext.getDispatcher().getEventHandler() > .handle(new RMNodeEvent(nodeId, RMNodeEventType.RECOMMISSION)); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)