[ https://issues.apache.org/jira/browse/YARN-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15027820#comment-15027820 ]
Wangda Tan commented on YARN-4304: ---------------------------------- Thanks for working on this [~sunilg] and review comments from [~Naganarasimha]. My thoughts/comments for output, haven't went through the patch. 1) I found you have RM node REST response in the zip, did you change any RMNodes related info? 2) Instead of putting max am to a separated object, I would prefer to put them to existing resourceUsageByPartition instead of introducing a new object. Even though max-am-limit is not usage, but it describes upper bound of usage. Thoughts? 3) And similarly, am-limit should put to queue capacities as well, now max_am_perc is a part of QueueCapacities. 4) When label is configured, max-am-percent and max-am-resource should in the above table of the RM UI (above table is for partition-specific properties and below table is for other general propoerties). 5) Is there any change to cluster metrics web UI? > AM max resource configuration per partition to be displayed/updated correctly > in UI and in various partition related metrics > ---------------------------------------------------------------------------------------------------------------------------- > > Key: YARN-4304 > URL: https://issues.apache.org/jira/browse/YARN-4304 > Project: Hadoop YARN > Issue Type: Sub-task > Components: webapp > Affects Versions: 2.7.1 > Reporter: Sunil G > Assignee: Sunil G > Attachments: 0001-YARN-4304.patch, 0002-YARN-4304.patch, > 0003-YARN-4304.patch, REST_and_UI.zip > > > As we are supporting per-partition level max AM resource percentage > configuration, UI and various metrics also need to display correct > configurations related to same. > For eg: Current UI still shows am-resource percentage per queue level. This > is to be updated correctly when label config is used. > - Display max-am-percentage per-partition in Scheduler UI (label also) and in > ClusterMetrics page > - Update queue/partition related metrics w.r.t per-partition > am-resource-percentage -- This message was sent by Atlassian JIRA (v6.3.4#6332)