[
https://issues.apache.org/jira/browse/YARN-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15035275#comment-15035275
]
Varun Saxena commented on YARN-3862:
------------------------------------
[~sjlee0], kindly review. Regarding some of the checkstyle comments.
If below two checkstyle issues have to be fixed, I think they should be fixed
for around 10 other variables as well. We are directly accessing these
variables in subclasses(***EntityReader). Do you want me to add getters and
setters for each one of them ?
{noformat}
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/storage/TimelineEntityReader.java:75:32:
Variable 'confsToRetrieve' must be private and have accessor methods.
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/storage/TimelineEntityReader.java:76:32:
Variable 'metricsToRetrieve' must be private and have accessor methods.
{noformat}
Below checkstyle issue is introduced because of javadoc. This import is
required in javadoc as I have a link to this class in javadoc. If I give full
classname along with package name, it threw multiple javadoc warnings in
previous build. So I guess this should be fine.
{noformat}
./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/storage/TimelineReader.java:31:8:
Unused import -
org.apache.hadoop.yarn.server.timelineservice.reader.filter.TimelinePrefixFilter.
{noformat}
> Support for fetching specific configs and metrics based on prefixes
> -------------------------------------------------------------------
>
> Key: YARN-3862
> URL: https://issues.apache.org/jira/browse/YARN-3862
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
> Affects Versions: YARN-2928
> Reporter: Varun Saxena
> Assignee: Varun Saxena
> Labels: yarn-2928-1st-milestone
> Attachments: YARN-3862-YARN-2928.wip.01.patch,
> YARN-3862-YARN-2928.wip.02.patch, YARN-3862-feature-YARN-2928.005.patch,
> YARN-3862-feature-YARN-2928.04.patch, YARN-3862-feature-YARN-2928.wip.03.patch
>
>
> Currently, we will retrieve all the contents of the field if that field is
> specified in the query API. In case of configs and metrics, this can become a
> lot of data even though the user doesn't need it. So we need to provide a way
> to query only a set of configs or metrics.
> As a comma spearated list of configs/metrics to be returned will be quite
> cumbersome to specify, we have to support either of the following options :
> # Prefix match
> # Regex
> # Group the configs/metrics and query that group.
> We also need a facility to specify a metric time window to return metrics in
> a that window. This may be useful in plotting graphs
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
