[
https://issues.apache.org/jira/browse/YARN-4421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15048093#comment-15048093
]
Rohith Sharma K S commented on YARN-4421:
-----------------------------------------
Initially in RM restart feature, there was some code that doing functionality
handling between those 2 lines. Later on because of improvements/bug, it has
been removed which looking now as dead code. It can be removed now.
> Remove dead code in RmAppImpl.RMAppRecoveredTransition
> ------------------------------------------------------
>
> Key: YARN-4421
> URL: https://issues.apache.org/jira/browse/YARN-4421
> Project: Hadoop YARN
> Issue Type: Improvement
> Components: resourcemanager
> Reporter: Daniel Templeton
> Assignee: Daniel Templeton
> Priority: Minor
> Attachments: YARN-4421.001.patch
>
>
> The {{transition()}} method contains the following:
> {code}
> // Last attempt is in final state, return ACCEPTED waiting for last
> // RMAppAttempt to send finished or failed event back.
> if (app.currentAttempt != null
> && (app.currentAttempt.getState() == RMAppAttemptState.KILLED
> || app.currentAttempt.getState() == RMAppAttemptState.FINISHED
> || (app.currentAttempt.getState() == RMAppAttemptState.FAILED
> && app.getNumFailedAppAttempts() == app.maxAppAttempts))) {
> return RMAppState.ACCEPTED;
> }
> // YARN-1507 is saving the application state after the application is
> // accepted. So after YARN-1507, an app is saved meaning it is accepted.
> // Thus we return ACCECPTED state on recovery.
> return RMAppState.ACCEPTED;
> {code}
> The {{if}} statement is fully redundant and can be eliminated.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
